Václav Pelíšek

Results 46 comments of Václav Pelíšek

I tried to work around the issue using JTI and I possibly found another bug, which may be related. ```php #[Entity(database: 'main')] class Question { #[Column(type: 'primary')] protected int $id;...

Hi, Mysql driver will suffice, as the mariadb maintains major compatibility with mysql. However, I am not sure about some other rdbms and its support for the check constraint. I...

In [ad29886](https://github.com/cycle/annotated/pull/100/commits/ad298862f2a6fabd152a91b3adb9a8b4e4256b8c) I added a logic to identify whether the property belongs to current entity or any parent entity in the hierarchy. This renders the note above as resolved.

Tests in CI fail due to phpunit deprecation, it is still needed to add a new testcases to cover the relevant usecases though.

Sure, right now I am working on a fix to #101 as it is somewhat related.

In [90989a4](https://github.com/cycle/annotated/pull/100/commits/90989a4e88d68e7c3504e47587ede43cc42f1ef9) I implemented a logic to lookup an entity which truly owns the property. This solves various issues: - Relations from JTI parent are not included in the child...

@roxblnfk Hi, I have downgraded mysql to 8.0 and also resolved the PHPUnit deprecation. However, there are 2 failing tests related to the `proxyFieldWithAnnotation` and I am currently not sure...

> Hi. It looks like this warning (Note) has gone off 😃 Yes, this is a side effect of this PR - to support base classes that are not entitites,...

> Hm.. The inheritance tests aren't passed even on the main branche > > > > Looks like this assertion has extra check `isset($parent)` > > https://github.com/cycle/annotated/blob/7dad356336ee70ef1f6e7b750274d4d215a691f1/src/TableInheritance.php#L69 > > >...

Hi @roxblnfk , thanks for looking into it! The metadata reader provider changes were made due to phpunits deprecation, which was introduced in 10.5.18.