Pekka Klärck

Results 725 comments of Pekka Klärck

The PR cannot be merged in the current form I could obviously fix it myself, but that's some extra work. If you really want to contribute, please fix the examples...

What benefits would this enhancement bring?

I understand benefits of reusable resource files. Could you clarify what benefits where would be having them on the remote server side and not where Robot actually is running? Local...

Proposed additions seem to explain the basic syntax and structure, not to explain how to create good test cases. In my opinion basics about the syntax belong to robotframework/QuickStartGuide or...

Yep, official support for `robot.api.logger` as well as for Python's `logging` module would be nice.

There are actually two bugs here: blindly using [inspect.getmembers()](https://docs.python.org/3/library/inspect.html#inspect.getmembers) with static libraries and the fact that this method is called at all with hybrid and dynamic libraries such as SeleniumLibrary....

Because there are two bugs, we probably should also have two bug reports. Fixing the problem with `inspect.getmembers()` would fix the issue with SeleniumLibrary, but avoiding calling that method in...

Do you mean that there should be more tests for this simple application? That could certainly be true, but the main purpose of this guide is demonstrating Robot Framework features,...

Good point. That ought to be mentioned in SeleniumLibrary installation instructions that are linked from README, but it would nevertheless be a good idea to mention browser drivers there explicitly.

Somewhat related to this, installation instructions should be changed not to use `requirements.txt`. See my comments to that here: https://github.com/robotframework/WebDemo/pull/6#issuecomment-478339713