pekingme

Results 21 comments of pekingme

Ah, agree. It looks very bad. To help us fix this better, what's the expected appearance of a "cut" label for slider in your case?

Thanks for the screenshot. The label used in the tweaked version is M2 version. But will let our design know the concern.

@DvTonder, thanks again for the PR. Could you try to squash all your commits into one? I have some difficulties to pull your PR into internal repo. I think the...

Thanks for working on this so quickly, @DvTonder. But it still doesn't work. When pulling a PR into Google internal repo, all the commits are considered as one change. The...

@DvTonder Thanks for trying. I'll do something similar on my end. Will delete the new PR you just created and associate the changes with this PR.

@DvTonder I managed to pull it into the internal repo. During the internal review, we noticed that we need some feedback from design for full-screen use case. Stay tuned.

In the current implementation, the rounded corners are draw as "decoration". The "real" progress is the rectangle between the left corners and the right corners. The clipping way was also...

I approved cuz' I didn't see the error mentioned in the issue with this change. But when I took another look, I cannot repro the error messages with the current...

Thanks for the recording! Yes, I can reproduce the same behavior with the catalog built **externally**. Was testing with the catalog built internally. It seems the fix works well with...

Ok, I have updated the fix (internally) to make it works for both 1.1.0 and later version. Should be merged soon.