vaadin4spring icon indicating copy to clipboard operation
vaadin4spring copied to clipboard

Vaadin 10 and SpringBoot 2

Open ekomrak opened this issue 6 years ago • 19 comments

Are you going to add support of Vaadin 10 and SpringBoot 2?

ekomrak avatar May 29 '18 17:05 ekomrak

~~Have you seen https://github.com/devsoap/gradle-vaadin-flow ?~~ Wrong project, not relevant. Please ignore.

christoph-frick avatar May 29 '18 17:05 christoph-frick

I'm using Security extension and EventBus, SideBar and MVP addons. It would be great to have it compatible with Vaadin 10 (MVP and SideBar) and SpringBoot 2 (Security)

ekomrak avatar May 29 '18 17:05 ekomrak

I think @peholmst is bit busy ATM, so help would be appreciated on this. I think the basics shouldn't be too hard to migrate as the fundamental architecture is not that much different.

I can certainly help, do code reviews and ask the core team for help when needed (e.g. opening some APIs), but I wouldn't like to take the lead on this.

mstahv avatar Jul 06 '18 08:07 mstahv

Can EventBus be used with Vaadin 10 without modifications?

andersforsell avatar Feb 08 '19 12:02 andersforsell

No, it will not work. The scopes are different in Vaadin 10.

peholmst avatar Feb 08 '19 12:02 peholmst

I made a PR for updating the event bus here

https://github.com/peholmst/vaadin4spring/pull/320

Although the project with that PR is in a state where it uses different versions than all other add-ons, so either they should be migrated, or maybe the event bus split out.

eriklumme avatar Feb 15 '19 07:02 eriklumme

Awesome! I think we should we create a separate flow branch and consider releasing the first version with only the event bus. What do you think @peholmst?

mstahv avatar Feb 15 '19 08:02 mstahv

That branch should probably remove all but platform compatible stuff and we can then later add features back when somebody finds time to work on the features.

mstahv avatar Feb 15 '19 08:02 mstahv

@mstahv Go for it!

peholmst avatar Feb 15 '19 08:02 peholmst

Landed the patch to flow branch. Let's use that to develop the first Flow version

mstahv avatar Feb 15 '19 09:02 mstahv

What is left to do for a first release with only the event bus? I am about to migrate a Vaadin 8 application to Vaadin 12 but would like to keep using the event bus.

andersforsell avatar Mar 12 '19 07:03 andersforsell

What is the future with event bus with Flow ? When we can expect release of event bus addon for Flow ? Event bus addon is important part of ours Vaadin 8 applications. We now need to migrate to Vaadin 13 preparing for Vaadin 14 development.

simpletasks avatar Apr 26 '19 10:04 simpletasks

I think we should definitely look to cut a first build. @eriklumme Do you think you could find out time for some short smoke test session?

mstahv avatar Apr 28 '19 15:04 mstahv

I made some proposal of updates for eventbus addon in #322 to be able to compile and run tests with flow version.

simpletasks avatar Apr 28 '19 21:04 simpletasks

I'll try to find time this week

eriklumme avatar Apr 29 '19 05:04 eriklumme

Vaadin 14 is just a few days away from being released so I understand if everyone is busy. The support for eventbus would be the last piece for me to be able to migrate an application from Vaadin 8. Any update?

andersforsell avatar Jun 30 '19 16:06 andersforsell

Vaadin 14 released, any update on this? @eriklumme

andersforsell avatar Aug 16 '19 06:08 andersforsell

Hi @andersforsell , I've been very busy lately so haven't had time to look at this, but it's high on my priority list.

It would also require some action from @peholmst in terms of checking out the already open PRs.

eriklumme avatar Aug 16 '19 06:08 eriklumme

@andersforsell Discussing with @peholmst, we decided that the event bus should probably be remade from scratch, due to the security issue explained here https://github.com/peholmst/vaadin4spring/blob/master/eventbus/README.md

In short, listeners in the application scope are notified within the security context of the sender, rather than that of the receiver. This is not an issue in the UI or session scopes.

Until the new version is completed, Petter released just the ported version of the old event bus. It can now be found on Maven central as version 14.0.0 https://mvnrepository.com/artifact/org.vaadin.spring.addons/vaadin-spring-addon-eventbus

eriklumme avatar Aug 26 '19 07:08 eriklumme