pega-helm-charts icon indicating copy to clipboard operation
pega-helm-charts copied to clipboard

ISSUE-240:Turning off Reverse DNS lookup

Open raghavf1 opened this issue 4 years ago • 2 comments

Reverse DNS is used to lookup the hostname of the IP address where the request is originating from. This is typically used for logging purposes, so domain names can be shown instead of IP addresses. However, this doesn't make sense in cloud and/or cluster deployments, since the originating IP address will be an internal address, e.g. the address of the load balancer etc. Since doing a reverse DNS will not provide any value, it will result in unneeded overhead. Reverse DNS lookups have also been shown to be a source of spikes, in case the DNS server / resolver get into temporarily non-responsive. Regarding backward compatibility: Since its main purpose is logging, there shoudn't be any b/w compatibility issues.

raghavf1 avatar Jan 26 '21 13:01 raghavf1

@raghavf1 Can you update the PR with an explanation of the change and that it will not impact backwards compatibility? Also you might want to fix the unit tests failed because of this change.

MadhuriArugula avatar Jan 27 '21 07:01 MadhuriArugula

@raghavf1 Can you update the PR with an explanation of the change and that it will not impact backwards compatibility? Also you might want to fix the unit tests failed because of this change.

@MadhuriArugula I have updated description of the PR and fixed the corresponding tests. Please let me know if you need any further info

raghavf1 avatar Jan 27 '21 11:01 raghavf1

Since there has been no activity on this pull request for the past year, I will proceed to close it. Please feel free to reopen it if necessary.

kishorv10 avatar May 29 '23 07:05 kishorv10