pega-datascientist-tools icon indicating copy to clipboard operation
pega-datascientist-tools copied to clipboard

Color assignments in Health Check are inconsistent

Open operdeck opened this issue 5 months ago • 0 comments

pdstools version checks

  • [X] I have checked that this issue has not already been reported.

  • [X] I have confirmed this bug exists on the latest version of pdstools.

Issue description

The various plots in the Health Check and Model Report have inconsistent assignments of values to colors. This is confusing - especially when copy/pasting the plots together into documents.

image

image

Reproducible example

See almost any of the generated HC reports

Expected behavior

The mapping of the various discrete axis should be consistent within one quarto notebook - not across different notebooks

We don't need to try to be very generic. Most plots in the Health Check with a discrete axis only use Channel/Direction. In a few places it is only Channel but arguably those should be using Channel/Direction instead.

For HC with predictor data we also have Predictor Category as a discrete option, as well as (in one place) EntryType (deserves a better name).

Plotly funcs often have a color_discrete_map argument that we should probably pass on as a dictionary from the ADMDatamart object - or something along those lines. We probably also want to fix the order of the categories with category_orders.

Installed versions

Replace this line with the output of pdstools.show_versions(), leave the backticks in place

operdeck avatar Aug 27 '24 07:08 operdeck