peerplays icon indicating copy to clipboard operation
peerplays copied to clipboard

GRPH-56 Implement transaction size check (18.04)

Open ronakpatel3110 opened this issue 5 years ago • 2 comments

ronakpatel3110 avatar Aug 22 '19 06:08 ronakpatel3110

@ronakpatel3110 : Can you provide steps to test this ? The QA team will need specific steps to reproduce and test the scenario.

bobinson avatar Sep 08 '19 18:09 bobinson

@bobinson 1) Rebase is done and sent PR to develop 2) It is not possible for QA to check this manually as we need to push many number of operations to reproduce this issue to increase the transaction size. To test this change, a new testcase is added broadcast_transaction_too_large.

In this test case, we are pushing multiple operations by below loop:

transfer_operation trans;
trans.from = cid_id;
trans.to   = account_id_type();
trans.amount = asset(1);
for(int i = 0; i < 250; ++i )
  trx.operations.push_back( trans );

ronakpatel3110 avatar Sep 09 '19 06:09 ronakpatel3110