peerplays icon indicating copy to clipboard operation
peerplays copied to clipboard

Published 20 hours ago • verified publisher icon peerplays-network

Referral Program

Open atlantic-blockchain opened this issue 5 years ago • 2 comments

Bug Description

Referral program may not being working as intended. Filing as bug, until the time where it is verified the referral program is working as designed.

Within the following file, /peerplays/libraries/chain/affiliate_payout.cpp there is no indication as to whether or not the users affiliate account is receiving the intended 20% of the rake.

The following file peerplays/libraries/chain/db_bet.cpp dictates which account will receive the 20% affiliate payout. It appears that the account that WON, is receiving the 20% payout, which means the funds are staying in the account that won.

Impacts

The peerplays referral program is impacted by this bug. If the funds never move from the winners hands, to the affiliates hands, then there is no incentive for anyone to be an affiliate partner for the peerplays blockchain.

Steps To Reproduce

  • Create an account (account-one)
  • Upgrade account-one
  • Create a second account (account-two) and use (account-one) as the referrer
  • Create a third account (account-three)
  • Give 10PPY to both account-two and account-three
  • Have account 2 place two bets, one on each side of the market, which will guarantee a win
  • Have account 3 take account-two's bets. Ensuring that account-two will win at least one bet
  • Upon resolution of the markets, check to see that account-one has received 20% of 1% of account-two's winnings

Expected Behavior

Upon resolution of the markets, check to see that account-one has received 20% of 1% of account-two's winnings

Impacts

  • [ ] API (the application programming interface)
  • [ ] Build (the build process or something prior to compiled code)
  • [ ] CLI (the command line wallet)
  • [ ] Deployment (the deployment process after building such as Docker, Gitlab, etc.)
  • [ ] P2P (the peer-to-peer network for transaction/block propagation)
  • [ ] Performance (system or user efficiency, etc.)
  • [ ] Protocol (the blockchain logic, consensus, validation, etc.)
  • [ ] Security (the security of system or user data, etc.)
  • [x] UX (the User Experience)
  • [ ] Other (please add below)

PBSA / Developer tasks

  • [x] Evaluate / Prioritize Bug Report
  • [ ] Refine User Stories / Requirements
  • [ ] Define Test Cases
  • [ ] Design / Develop Solution
  • [ ] Perform QA/Testing
  • [ ] Update Documentation

atlantic-blockchain avatar Oct 17 '19 17:10 atlantic-blockchain

@atlantic-blockchain - This is reported against the current mainnet or TESTNET ?

bobinson avatar Oct 17 '19 20:10 bobinson

@atlantic-blockchain - This is reported against the current mainnet or TESTNET ?

MainNet

atlantic-blockchain avatar Oct 17 '19 20:10 atlantic-blockchain