ecto_diff icon indicating copy to clipboard operation
ecto_diff copied to clipboard

Add diff for many associations without primary keys

Open ddidwyll opened this issue 3 years ago • 5 comments
trafficstars

Hi, I actively use ecto_diff in my projects, and sometimes I miss the ability to diff on embeds_many associations without a primary key. I propose a patch to add this feature.

ddidwyll avatar Jan 11 '22 12:01 ddidwyll

Hello, @ddidwyll! This is your first Pull Request that will be reviewed by SourceLevel, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

sourcelevel-bot[bot] avatar Jan 11 '22 12:01 sourcelevel-bot[bot]

Hello! Thank you for the PR! :tada:

It would be fantastic if you could include a test for this feature. Is that possible?

vanvoljg avatar Jan 13 '22 01:01 vanvoljg

Yes, of course, I'll write tests a little later.

ddidwyll avatar Jan 13 '22 09:01 ddidwyll

I wrote a small test that shows how this feature can work.

ddidwyll avatar Jan 14 '22 09:01 ddidwyll

Hello! Sorry about the delay in getting back to you. Too many GitHub notifications. I'll take a look at these changes shortly!

vanvoljg avatar Feb 10 '22 05:02 vanvoljg