EffectiveAndroidUI icon indicating copy to clipboard operation
EffectiveAndroidUI copied to clipboard

ButterKnife Fragment unbinding

Open npace opened this issue 9 years ago • 4 comments

Hey, shouldn't you call ButterKnife.unbind(unbinder) in your BaseFragment's onDestroyView(..) callback?

npace avatar Mar 21 '17 14:03 npace

Should.

Rainer-Lang avatar Mar 21 '17 16:03 Rainer-Lang

It could be a nice improvement 😃

pedrovgs avatar Mar 27 '17 12:03 pedrovgs

The project uses the old version of ButterKnife (5.1.+) which doesn't have the unbind(unbinder) method. So, @npace, the answer is no. :) But I believe, used libraries should be updated to latest versions.

DmitriyZaitsev avatar Mar 27 '17 13:03 DmitriyZaitsev

We should update the dependency version before adding this improvement.

pedrovgs avatar Mar 27 '17 13:03 pedrovgs