react-bnb-gallery icon indicating copy to clipboard operation
react-bnb-gallery copied to clipboard

Published 20 hours ago • verified publisher icon pedropalau

React 17 support

Open apepper opened this issue 3 years ago • 5 comments

Currently react-bnb-gallery supports react 15 and 16:

https://github.com/peterpalau/react-bnb-gallery/blob/ad411497c42c1bbdf8c16c7e4ab5a35844a9529a/package.json#L58-L61

It would be great, if it would also support the latest React 17 release.

apepper avatar Oct 29 '20 08:10 apepper

Please note that the sub-dependency focus-trap-react currently does not support react 17 yet:

https://github.com/peterpalau/react-bnb-gallery/blob/ad411497c42c1bbdf8c16c7e4ab5a35844a9529a/package.json#L130

At least not a released version. My guess is, that version 8.2.0 will have a fix, once it is released (see merged but not yet released PR).

apepper avatar Oct 29 '20 08:10 apepper

focus-trap-react is now compatible with react 17 starting with version 8.1.1 or newer (see https://github.com/focus-trap/focus-trap-react/releases/tag/v8.1.1).

apepper avatar Mar 10 '21 11:03 apepper

@peterpalau any movement here?

joeyfigaro avatar Oct 06 '21 17:10 joeyfigaro

Opened a simple PR for this – #90

joeyfigaro avatar Oct 06 '21 17:10 joeyfigaro

...looks like the airbnb proptypes package does not currently support React 17. This is probably held up until they fix that–or the dependency is dropped/removed.

joeyfigaro avatar Oct 06 '21 18:10 joeyfigaro