Tab component reverts to first tab whenever parent component renders

[matthewgertner]

I'm embedding your component in another React component. Every time I emit a change event in one of the tabs, the tab component displays the first tab. The problem seems to be the componentWillReceiveProps method. It always sets the state to the "new" tabActive property even if it is the same as the old tabActive property. As a result, if you don't pass in the prop explicitly, it reverts to the default value on every render. Wouldn't it be better to have the following?

  componentWillReceiveProps: function(newProps){
    if(newProps.tabActive && newProps.tabActive !== this.props.tabActive){
      this.setState({tabActive: newProps.tabActive})
    }
  }

Or am I misunderstanding something?

[ustccjw]

+1

[theogravity]

+1

[theogravity]

@matthewgertner Given that the author has been unresponsive for months, may I ask you to publish your PR as a node module (eg react-simpletabbed)?

[maccman]

+1

[matthewgertner]

@pedronauck Making a last effort to get your attention. Any chance you can accept the PR and publish a new NPM package?

[dmatteo]

~~@matthewgertner fork his version on your repo, tag it and use the tar package in your package.json~~

Got confused with who was unresponsive :D

[theogravity]

@matthewgertner I think it's safe to fork and publish a new one.

[matthewgertner]

Okay I'll get it done this week.

[theogravity]

:+1: