Pedro Pedreira
Pedro Pedreira
Cc: @kgpai @assignUser
> @pedroerp something we can open a PR for or it needs to be looked at by someone else first (for Meta internal processes?) Please go ahead and open a...
Another option is to use: https://github.com/facebookincubator/velox/blob/main/velox/type/Timestamp.cpp#L78 it supports conversions of timezone offsets without relying on velox/external/date. It would be nice to align on a single method to support timezone offsets...
> Do you mean we can just use tzID to support offset-based timezone, like https://github.com/facebookincubator/velox/pull/9403? Yes :) > Does the community plan to remove velox/external/date at some time point? velox/external/date...
> Do you have a plan to extend DictionaryVector to wrap more than one vectors, so that in some cases it can avoid too small-sized batches? that's a great question....
That is slightly different though; I guess there is a point is potentially making dictionaries able to wrap around more than one inner vector.
> This is possible but will be a very big change and need to fix the UDFs to handle this. I guess this should be mostly covered if we assume...
Just getting to this discussion. Are there any updates? Overall I agree with the point that the batching should be done in the source operator; essentially making sure that operators...
Like we discussed on Slack, something like this should work. We would just need to give it a long enough fuzzer run to make sure it won't trigger any dormant...
> @pedroerp All comments are resolved, so is there any further action needed? thank you @Donvi . I'm triggering the CI jobs again