pushwoosh icon indicating copy to clipboard operation
pushwoosh copied to clipboard

Published 20 hours ago • verified publisher icon pedroandrade

Update push_notification.rb

Open muzammalaslam opened this issue 7 years ago • 4 comments

Default notification option change

muzammalaslam avatar Jun 22 '17 06:06 muzammalaslam

Hi @muzammalaslam , could you provide a little context regarding the reason behind this change?

antillas21 avatar Jun 22 '17 17:06 antillas21

Hi antillas21 https://github.com/antillas21, There is an issue for sending push notification that if we don't want to increase the badges for some push notifications like silent push its also increase. I did alot of discussion with pushwoosh Support. They said that its not there default behavior. Gem is not compatible. So, I change it according to it and my issue is resolved. Thanks, Regards, Muzammal Aslam

On Thu, Jun 22, 2017 at 10:31 PM, Antonio Antillon <[email protected]

wrote:

Hi @muzammalaslam https://github.com/muzammalaslam , could you provide a little context regarding the reason behind this change?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pedroandrade/pushwoosh/pull/25#issuecomment-310448724, or mute the thread https://github.com/notifications/unsubscribe-auth/ALgATLMHpuSMiDRyuoaEuK71qCUeUYMKks5sGqTggaJpZM4OB368 .

muzammalaslam avatar Jun 23 '17 05:06 muzammalaslam

Thanks for the clarification @muzammalaslam 😄

Does this look good to you @pedroandrade ?

antillas21 avatar Jun 23 '17 05:06 antillas21

Sounds great @muzammalaslam and @antillas21

@muzammalaslam could you fix the spec?

pedroandrade avatar Jun 23 '17 12:06 pedroandrade