Peter Hull

I've done a bit more looking at this, and I believe it is down to way that NB checks for accessible classes (accessible in the sense of public / private...

As a bonus the IDE now shows the package with an unlocked padlock icon as it is exported from that module. (left: without patch, right: with patch) 

Follow up: https://bugs.openjdk.org/browse/JDK-8255464 The API to access the module was not available in JDKs 9 to 16 inclusive, which may be an issue for older JDK platforms. [edit] - looking...

I believe I have solved this and another case where the cause was the same.

It predates all of us! - it was part of an Allegro 4 datafile that was in JB's original code. I edited it though in 2008 to add in the...

This is the same kind of issue as #8560 actually - the addition of `getModule()` to the API. I applied this patch ``` diff --git a/java/java.source.base/src/org/netbeans/modules/java/source/JavaSourceUtilImpl.java b/java/java.source.base/src/org/netbeans/modules/java/source/JavaSourceUtilImpl.java index ddb82083e4..7611aa0fb0 100644...

Alright, that last test fail is because `SourceLevelQueryImplTest` tries to set a Security Manager and that's not allowed any more. Can we just delete it do you think? https://github.com/apache/netbeans/blob/e80ec881f2f4c1950c8e3a317ff2be2f35a20603/java/java.api.common/test/unit/src/org/netbeans/modules/java/api/common/queries/SourceLevelQueryImplTest.java#L66-L83

This seems a bit wider than my original bug (I would bet not many people have been blocked by not being able to detect missing javadocs in a modular ant...

Following up on this, I found one other piece of code where this API change would have an effect but looking at its caller I don't believe it could ever...

I tried this on the current development version of vscode-tmlanguage (i.e. not the one on the marketplace) which contains the fix for #12, on a file `foo.tmLanguage.yaml` containing just this:...