pedr

Results 26 comments of pedr

*There is one part here that is missing*, we aren't updating the platform, type and version values. They are set at the start of the process (when the user get...

I update the branch with the fixes and merged with upstream dev.

I changed the implementation to be able to cancel the setInterval and show the error message when the `checkIfLoginWasSuccessful` function throws an error, I think this is more inline to...

Last changes: - Flatten the body of request to `api/sessions` - Change the URLs for the new Joplin Cloud login process I also add images about how the feature looks...

Last changes: - Renamed `api/applications` endpoint to `api/application_auth` - Changed the unique login code value name to application auth id

> > Files that are using `escapeHtml` function and might be affected: > > ``` > > packages/lib/htmlUtils.ts > > packages/lib/services/interop/InteropService_Exporter_Html.ts > > packages/server/src/routes/index/home.ts > > packages/server/src/utils/csrf.ts > > packages/tools/update-readme-sponsors.ts...

I was looking at the problem and it seems to happen because `packages/app-desktop/plugins/GotoAnything.tsx` component calls the `surroundKeywords` with `{ escapeHtml: true }` which is transforming in entities any character that...

> Isn't it because we display it in HTML so it needs to be escaped? I understand that chars like < > need to be escaped for security reasons, but...

> > but characters like é ó ã ç can be displayed as they are, as far as I know. > > Yes but even then it doesn't really matter....