Net_URL2 icon indicating copy to clipboard operation
Net_URL2 copied to clipboard

Fix tests for PHPUnit 12

Open williamdes opened this issue 5 months ago • 1 comments

While running phpunit tests I got some concerning warnings, I fixed them

1) Net_URL2Test::testNormalize
* Data set #0 provided by Net_URL2Test::provideEquivalentUrlLists has more arguments (2) than the test method accepts (1)

* Data set #1 provided by Net_URL2Test::provideEquivalentUrlLists has more arguments (2) than the test method accepts (1)

* Data set #2 provided by Net_URL2Test::provideEquivalentUrlLists has more arguments (2) than the test method accepts (1)

* Data set #3 provided by Net_URL2Test::provideEquivalentUrlLists has more arguments (2) than the test method accepts (1)

* Data set #4 provided by Net_URL2Test::provideEquivalentUrlLists has more arguments (4) than the test method accepts (1)

* Data set #5 provided by Net_URL2Test::provideEquivalentUrlLists has more arguments (2) than the test method accepts (1)

* Data set #6 provided by Net_URL2Test::provideEquivalentUrlLists has more arguments (2) than the test method accepts (1)

/mnt/Dev/@debian/@qa/php-net-url2/Net_URL2-2.2.3/tests/Net/URL2Test.php:864

2) Net_URL2Test::testConstructSelf
* Data set #0 provided by Net_URL2Test::provideEquivalentUrlLists has more arguments (2) than the test method accepts (0)

* Data set #1 provided by Net_URL2Test::provideEquivalentUrlLists has more arguments (2) than the test method accepts (0)

* Data set #2 provided by Net_URL2Test::provideEquivalentUrlLists has more arguments (2) than the test method accepts (0)

* Data set #3 provided by Net_URL2Test::provideEquivalentUrlLists has more arguments (2) than the test method accepts (0)

* Data set #4 provided by Net_URL2Test::provideEquivalentUrlLists has more arguments (4) than the test method accepts (0)

* Data set #5 provided by Net_URL2Test::provideEquivalentUrlLists has more arguments (2) than the test method accepts (0)

* Data set #6 provided by Net_URL2Test::provideEquivalentUrlLists has more arguments (2) than the test method accepts (0)

/mnt/Dev/@debian/@qa/php-net-url2/Net_URL2-2.2.3/tests/Net/URL2Test.php:953

williamdes avatar Sep 08 '25 14:09 williamdes

I also did add some bumps to match what is tested by CIs: https://github.com/pear/Net_URL2/pull/22/commits/8f6978d7dac89e7dd067e0e64245bfe1bef4a265

I am not sure that old PHP projects need updates

williamdes avatar Sep 08 '25 15:09 williamdes