peakschris

Thank you! This isn't working: ``` D:\udu\units\cb_0523_bazel2>bazel-mod-dot build //src/server/soa_framework/common/cpp/... INFO: repository @@our_toolchain.' used the following cache hits instead of downloading the corresponding file. * Hash 'b5d45176a23aaa3173d2b6560df57283490e6756253ed4fb11b3855c1178eae1' for If the definition...

"+" seems to work on windows anywhere in filename without quoting in shell: ``` D:\workdir>mkdir _main+our_toolchain+ D:\workdir>dir _main+our_toolchain+ Volume in drive D is Data Volume Serial Number is 982B-CBB1 Directory...

I will make a local change to + and retry, now I know where the code changes should go

I tested: - start with https://github.com/fmeum/bazel/tree/22865-windows-tilde - modify all '.' to '+' - change https://github.com/bazelbuild/bazel/blob/3324f06cbd55ffadd497ca21e94ddb30a7675898/src/main/java/com/google/devtools/build/lib/cmdline/RepositoryName.java#L45 to allow '+' - modify our internal rules in 3 places where they were relying...

@fmeum you're welcome, glad to get to the bottom of this. Would this be a breaking change, behind a flag? As an aside, when I'm building bazel should I expect...

There are two further lines that need changing in src\main\java\com\google\devtools\build\lib\bazel\bzlmod\ModuleExtensionId.java

@meteorcloudy that's correct, disabling 8.3 filenames does not fix this bug

Wyverald, sounds like an epic debug session! Hope you've recovered... thank you for your work on this.

Just to say that I've tested this flag in 7.3.0rc1, and it is working for our monorepo. The performance issue is resolved. Thank you for your work on this, and...

@meteorcloudy how about: instead of this: `vendor\_main~main_extension~nuget.runtime.osx.10.10-x64.runtime.native.system.security.cryptography.openssl.v4.3.3\_main~main_extension~nuget.runtime.osx.10.10-x64.runtime.native.system.security.cryptography.openssl.v4.3.3.zip` the zip is named: `vendor\_main~main_extension~nuget.runtime.osx.10.10-x64.runtime.native.system.security.cryptography.openssl.v4.3.3\vendor.zip`