s5cmd icon indicating copy to clipboard operation
s5cmd copied to clipboard

fix: renew the session token when the token expires

Open MqllR opened this issue 2 years ago • 3 comments

This PR fix https://github.com/peak/s5cmd/issues/678

In a Kubernetes context, when running a very long process, we can easily fall into the ExpiredToken error. In order to not introduce any performance degradation, I propose to keep to global variable caching the session token but clear it when catching this specific error. The session will be renewed by reading again the projected volume /var/run/secrets/eks.amazonaws.com/serviceaccount/token.

MqllR avatar Dec 05 '23 14:12 MqllR

this is also an issue on our side and could speed up the review & release process? thank you.

jasonyic avatar Dec 26 '23 04:12 jasonyic

+1, this would be great to have!

l1n avatar Aug 01 '24 18:08 l1n

@MqllR does the error only happen if s5cmd runs for more than hour? or it happens when trying to run short s5cmd on pod that is older than an hour?

tooptoop4 avatar Sep 28 '24 06:09 tooptoop4