peachpie icon indicating copy to clipboard operation
peachpie copied to clipboard

Published 20 hours ago • verified publisher icon peachpiecompiler

Fixes C14N, PDO.PgSQL, chr()

Open kripper opened this issue 3 years ago • 3 comments

@jakubmisek here is a patch for the C14N bug. Can you also please merge my helper function "peachpie_set_string_encoding()" which is required to change encoding and be able to work with ISO-8859-1 sources. It won't harm the project, but will be usefull/required to work with ISO-8859-1 sources.

kripper avatar Sep 07 '22 22:09 kripper

thanks @kripper

jakubmisek avatar Sep 09 '22 23:09 jakubmisek

Can we have the PR without the change to Strings.cs, it's totally unrelated to the issue.

thank you

jakubmisek avatar Sep 11 '22 11:09 jakubmisek

Please note that the helper method needed for working with iso-8859-1 and utf-8 at the same time, was reverted here: https://github.com/peachpiecompiler/peachpie/commit/280800183060e500a1c0ae0020663ec1b7536970

We have been using this method in production for years and we really need it, since there is no other option.

Having this method in our code, is also an obstacle for us to release pull requests of all other fixes that are required upstream.

We don't know how to deal with this method.

kripper avatar Apr 02 '23 15:04 kripper