actions-suggest-related-links icon indicating copy to clipboard operation
actions-suggest-related-links copied to clipboard

test unclickable false

Open peaceiris opened this issue 3 years ago • 1 comments

Description

Currently, all files that are set to be ignored in .gitignore will not be deployed by the action. This seems to be caused by the git clone operation and, while I haven't been able to find any discussion on this in issues or PRs (I used github's search tool, so I might be on the wrong here), I think it's safe to assume that this is the intended behaviour.

I believe that this behaviour could be counterintuitive to some users, so it may be interesting to document it on the readme, or at least discuss the idea here.

Reproduction

  1. Create a repository that includes a .gitignore file that blacklists some files
  2. Set up a CI pipeline that deploys the directory that contains the .gitignore file using this action
  3. Files specified on .gitignore will not be deployed

You can see this behaviour on this CI run.

Reasons why this can be unexpected

I personally got confused by this behaviour, as I expected .gitignored files to be deployed. My thought process went along the lines of:

  1. People usually deploy build artifacts
  2. Build artifacts are usually excluded from git through .gitignore
  3. Thus, .gitignore files are probably not ignored when deploying

peaceiris avatar Sep 17 '20 21:09 peaceiris