Rough add withdeploy

[arnaudlevy]

Fix #658

Missing tests, not even tried as I don't have all the setup. Hope the PR is not too bad.

[deining]

Thanks for this PR! I took it over to my fork of this repo, made a release there and tested this release with one of my projects. Everything worked like a charm, great job! Looking forward seeing this PR merged soon.

[Fale]

what's missing for this to get merged?

[SebouChu]

Hello @PScoriae! Any update or schedule about this being merged? Thanks!

[mschfh]

@peaceiris Could we please get this merged?

[jbouse]

This lacks the proper condition testing that #663 included that ensured that both extended and withdeploy were set to get the extended/withDeploy edition of Hugo. This appears to not gracefully catch this situation if you don't set extended to True along with adding withdeploy.

[arnaudlevy]

@jbouse you are perfectly right!

May I remind you that it's completely broken right now? Perhaps, if you don't feel like coding the fix yourself, you could open an issue for what you are pointing? Merging the PR would allow everyone to use this action with the proper Hugo version.

A notice in the readme would be a good thing too, while it's not fixed, what do you think?

[jorkle]

Hi All,

I have been leveraging the peaceiris/actions-hugo for the github actions deployment pipeline that I have in place to automatically deploy to my staging and production environments for my blog (jorkle.com).

I've been watching this pending merge for the 'withdeploy' fix for a month or so as the hugo theme I happen to use leverages features from a hugo version after the withdeploy was added. Meaning that I was unable to leverage the Hugo FixIt theme with my github action for auto deployments to AWS S3 until this fix was merged.

I went ahead and tried to test this proposed fix for the 'withdeploy' issue and wanted to share the results and logs in the event this information would be helpful for your testing/validation purposes of this merge request.

To test the this 'withdeploy' fix I did the following:

1. I created a fork of peaceiris/actions-hugo (https://github.com/jorkle/actions-hugo-withdeploy-temp)
2. I added the "https://github.com/noesya/actions-hugo/tree/main" as a git remote with git remote add fix "https://github.com/noesya/actions-hugo/tree/main"
3. I merged the changes locally for the two remotes. (git config pull.rebase false, git pull fix main, git push origin main)
4. Now that https://github.com/jorkle/actions-hugo-withdeploy-temp has the changes from 'noesya/actions-hugo' merged. I ran the "release.sh" to generate a release (./release.sh)
5. I updated my the github actions 'deploy-staging.yml' that I use for my blog https://jorkle.com to use uses: jorkle/actions-hugo-withdeploy-temp@88ed9e517c81f665fd90e09f2ff9fa27ac3e7cb8 instead of uses: peaceirus/actions-hugo....
6. Initially I encountered an issue because I set the 'hugo-version' field in the actions yaml file to be '0.137.0. But this issue was unrelated to this merge. The issue was due to the fact that the Hugo FixIt theme leverages a feature that was added in Hugo version 0.144.0 ("try" function). So I updated the hugo-version line in the github actions yaml to use '0.144.1' as the hugo version.
7. After making that change for the issue (not due to the proposed merge/fix) the github actions for my blogs deployment ran successfully.

I've included below a copy of the Github Actions yaml file that I tested this proposed fix with along with the log file from the successful github actions run. I've censored out the mention of my S3 bucket's name for my blog from the github actions log file. Everything else is verbatim.

Github Actions file (that I leveraged this proposed 'withdeploy' fix) for my blogs deployment: https://gist.github.com/jorkle/28e8dbf05f90d946f57bb4ea5c1bdc8b Git Actions log file (from the execution of the linked github action file): https://gist.github.com/jorkle/e65302e75450abea021d1832d1263c95

[razor-1]

@peaceiris this should be good to go now, can we get it merged and a new release cut to un-break production usage? Thank you

[SebouChu]

@peaceiris Any news about this? Thanks ❤️

[arnaudlevy]

Hi @peaceiris do you need anything to merge this? Can we help? Thanks!

[SebouChu]

Given the situation is locked for almost 7 months, on our side, we now use a release branch of this fork to be able to use the latest Hugo version with the withdeploy option. See here for example: https://github.com/osunyorg/admin/commit/f298c507f340bf0a1b13e8fed013dc769f3e30b2

@peaceiris Please keep us updated on when you can merge this PR. That would be great. Thanks :)

[jason-dour-e]

Seven months with no resolution; several months since adequate code available if the above thread is to be believe.

Sounds like it is time to back a forked and rebranded version of this Action.