actions-hugo icon indicating copy to clipboard operation
actions-hugo copied to clipboard

proposal: hugo >0.137.0: offer possibility to use 'withdeploy' release

Open deining opened this issue 1 year ago • 5 comments

Checklist

  • [X] I am using the latest version of this action.
  • [X] I have read the latest README and followed the instructions.
  • [X] I have read the latest GitHub Actions official documentation and learned the basic spec and concepts.

Describe your proposal

As of hugo version 0.137.0, the deploy subcommand is not part of hugo's extended version any more. If you still want to make use of hugo deploy feature, you have to download and install a release with withdeploy in the archive filename. See https://github.com/gohugoio/hugo/pull/12995 for further details.

Describe the solution you'd like

As far as I can see, currently it is not possible to make use of the withdeploy version inside of a workflow definition. Therefore I would like to propose to introduce a new boolean option withdeploy that allows to make use of the hugo version that includes the deploy feature:

      - name: Setup Hugo
        uses: peaceiris/actions-hugo@v3
        with:
          hugo-version: '0.119.0'
          extended: true
          withdeploy: true  # <-- request to add this new option

Describe alternatives you've considered

None

Additional context

None

deining avatar Nov 04 '24 22:11 deining

Yeah, not having this option breaks any GA based deployment workflows.

andrlik avatar Nov 05 '24 14:11 andrlik

Nice catch! ʕ◔ϖ◔ʔ

  • https://github.com/peaceiris/actions-hugo/pull/659 is in progress

peaceiris avatar Nov 05 '24 16:11 peaceiris

On consideration that the existing #659 doesn't check or enforce is that withdeploy is implicitly extended as it is extended_withdeploy not just withdeploy.

I didn't see anything that would catch the following invalid config:

      - name: Setup Hugo
        uses: peaceiris/actions-hugo@v3
        with:
          hugo-version: '0.137.0'
          # extended: false # Default is actually false
          withdeploy: true  # <-- request to add this new option

jbouse avatar Dec 06 '24 03:12 jbouse

The concern about extended is now resolved in the MR. It should be merged and this issue resolved.

razor-1 avatar Apr 14 '25 20:04 razor-1

@peaceiris - Please keep us updated if you can look into merging the PR which has now fixed the extended issue.

loganmarchione avatar Jul 22 '25 15:07 loganmarchione