Peace

Results 289 comments of Peace

@kadir-akbulut A number of people have encountered this type of issue. What solution did you find works best?

Thanks @allroundexperts This looks good, with issues from the previous PR addressed. I would recommend against including react-native-vector-icons in this library because that requires native linking. Not everyone who uses...

👍 Did you update the sample app to reflect the latest changes? I'm not at my computer to test it

I'll have time to test this soon. A few more items need to be addressed: Some of the props/methods have changed names (`getSelectedItem` and `selectedItem`). This should be documented in...

@allroundexperts Thank you for continuing to refine this PR. Apologies for the delay in processing this. The sample app in master has been updated to a simpler Expo project. Please...

The cancel button fires `close()` which calls `this.props.onModalClose(item)`. That always fires when the cancel button is pressed. https://github.com/peacechen/react-native-modal-selector/blob/master/index.js#L193 If you're creating the button yourself, you have complete control over its...

Try `optionContainerStyle ` https://github.com/peacechen/react-native-modal-selector/blob/master/index.js#L264 https://github.com/peacechen/react-native-modal-selector#props You are welcome to submit a PR if you find a way to customize the modal the way you like.

`onChange` wasn't called for some users. What version of RN are you using? There was a breaking change in RN around 0.5 or 0.6 that necessitated the recent PR. We...

This currently isn't supported, but would be a great enhancement. Would you submit a PR to add this feature?

There are unfortunately too many variations in RN's modal behavior of `onDismiss`. It may be better to not use that internally. Would you mind testing these options: 1. Delete the...