Jamie Isaacs
Jamie Isaacs
Using the term emit() is misleading as events are not actually emitted, only staged for release. Replace with raise() to better indicate the actual behavior. https://github.com/inklabs/goauth2/search?q=emit&unscoped_q=emit
This line will fail if no default logger is injected. https://github.com/inklabs/goauth2/blob/7c2bedaafaca9e4b8cb62be10deda3ba4e7adf6f/goauth2.go#L175 TODO: - Modify goauth2.New to instantiate a default logger
Convert the following request to use value objects. ``` php $ups = new UPS\Rate([ 'prod' => FALSE, 'accessKey' => 'XXXX', 'userId' => 'XXXX', 'password' => 'XXXX', 'shipperNumber' => 'XXXX', 'shipment'...