David Philip

Results 19 comments of David Philip

I guess just the `toDo()`s - I've tested all the changes with my existing Test Suite covering 207 tests, though those don't include the cursor and bulk tests. Anyway, I'll...

@use-the-fork your CI is excellent, tested it and works great. Well done. I'm going to leave the `todo` tests for now as is and prepare this release (update docs etc)...

Also, if you'd like to be in touch, shoot me an email (in composer)

@sporchia , just so I understand. You've found no issue with the package itself, just an incomplete/erroneous doc block? The tests for this method are here: https://github.com/pdphilip/laravel-elasticsearch-tests/blob/main/tests/EloquentTests/EloquentQueriesTest.php#L778-L803 - which is...

From help from the community, the package has been refactored with PHPstan integration - which applies to your query here. V4.1.0 will have these changes.

Hey @use-the-fork, appreciate your work here but pump the brakes on this one. I'm busy rewriting the docs to break down each section in MDX & to include versioning history....

Thanks @use-the-fork, will have a look here when I get a chance

Hey @use-the-fork , thanks for putting this one together. It's been published in v4.5.0 Just note that I changed the option name from `perform_unsafe_queries` to `bypass_map_validation`. `perform_unsafe_queries` may be construed...