Peter Dimov

This adds a test for `boost::compute::detail::sha1`, using the test vectors from Wikipedia.

... per https://en.wikipedia.org/wiki/Xcode#Toolchain_versions

Use BOOST_ASSERT instead of a private assert macro for span

5

Instead of removing assertions under GCC 4.x to retain constexpr support, this retains the assertions and removes constexpr support under GCC 4.x instead. The presumption is that GCC 4.x users...

Investigate simpler, more Nlohmann-like, custom conversions

1

For the type ``` struct X { std::vector a; int b; }; ``` our current solution, if we assume lack of physical dependency on Boost.JSON, is ``` namespace boost {...

Recover ability to initialize `json::value` directly from C++ objects by way of automatically using `value_from`

1

As shown in https://github.com/boostorg/json/issues/1125, the natural implementation of `value_from` for simple structs ``` void tag_invoke( boost::json::value_from_tag const&, boost::json::value& jv, X const& x ) { jv = { { "a", boost::json::value_from(...

E.g. ``` struct X { std::vector a; int b; }; ``` Be sure to prominently explain that the natural implementation of `value_from` ``` void tag_invoke( boost::json::value_from_tag const&, boost::json::value& jv, X...

``` boost::system::result< unsigned char > oct1 = try_value_to< unsigned char >( arr[0] ); if( !oct1 ) return make_error_code( std::errc::invalid_argument ); ``` This should be ``` if( !oct1 ) return oct1.error();...

Currently, the conversions for `ip_address` in the documentation are written to only use its public interface; this presumably demonstrates how conversions can be implemented non-intrusively without modifying the original (third-party)...

CMake 3.12 requirement

2

CMake 3.12 is required here https://github.com/boostorg/histogram/blob/3afe76f91f93af237764242d56fa6ebaad7c81e6/CMakeLists.txt#L6 but I'm not sure why; from a quick look at the CML files nothing seems to need it. Ubuntu 18.04 has CMake 3.10, and...

Asio is not installed by CMake in Boost 1.89.0

7

See https://github.com/boostorg/cmake/issues/85. Probably caused by https://github.com/boostorg/asio/commit/be4af2d923f6145cd384e9bd1d572a5f204f5461. When making changes to CMakeLists.txt, please test installation (and ideally add_subdirectory use as well.)