Peter Dimov

Results 371 comments of Peter Dimov

I already forgot everything we discussed, so could you please bring me up to date? What is the specific split we're considering, that is, how should the split repositories be...

Our repositories correspond to directories under `libs/`, and as a rule we don't use dashes in those. Assuming underscores, the repos above would correspond to libs/spirit_classic libs/spirit_v2 libs/spirit_x3 Is that...

To clarify once again, in the Boost 1.89 release tarball we have `libs/spirit` and after the proposed changes, in the Boost 1.90 release tarball we won't have `libs/spirit`, but `libs/spirit_classic`,...

My style would be to keep `spirit` the classic one and add `spirit2` and `spirit3`, but that's obviously not the preference here. :-)

> Spirit's `CMakeLists.txt` is already broken. I don't know what you consider broken, but e.g. Serialization uses Boost::spirit in its CMakeLists.txt file, and builds with CMake, so it's obviously not...

> A well-established build script that does not follow the best practices shall be considered broken. What best practices does it not follow? > Let's stop talking about this. It's...

The autogenerated CML gets the C++ level from meta/libraries.json, and since Spirit classic supports C++03, your meta/libraries.json specifies C++03: https://github.com/boostorg/spirit/blob/70f968ef6cda4295d65421068457eef3b4308882/meta/libraries.json#L18 If you put something else there, `boostdep --cmake` will add...

> Can you stop complaining about my decisions in the first place? I only care about your decisions when I'm forced to. I would like nothing more than not having...

I suspect that we'll have fewer problems if we retain libs/spirit (and boostorg/spirit) to be classic. It's not ideal from discoverability perspective, but if we put a large and prominent...

> I think, a user-provided tag_invoke should always be preferred even if the type matches one of the natively supported type category. That's the usual practice and was what I...