pdfpc icon indicating copy to clipboard operation
pdfpc copied to clipboard

Add options in rc file to change counter symbols

Open jonasc opened this issue 1 year ago • 8 comments

For reasons unknown to me, I was never able to get the count-down and count-up arrows to render properly. I had a brief look and decided it might be easiest to allow the user to change the symbol displayed in the two situations. If you decide that it makes sense to include the proposed changes for all users, I'd be happy to have this pull request accepted.

jonasc avatar Mar 15 '23 14:03 jonasc

Hmm, so how do the symbols look by default in your case, and which ones do you define?

fnevgeny avatar Mar 15 '23 14:03 fnevgeny

They just show the generic square with 2B0A or 2B08 for symbols it could not find. It is a bit weird, as in all other places tested so far it renders just fine (browser, mail client, command line, etc…).

The symbols I tried are nf-md-sort_clock_ascending and nf-md-sort_clock_descending from the nerd fonts package, which for whatever reason do work for me.

jonasc avatar Mar 15 '23 14:03 jonasc

Maybe you can put in $XDG_CONFIG_HOME/pdfpc/pdfpc.css something like

.bottomText {
    font-family: <your-favorite-sufficiently-complete-unicode-font>;
}```

fnevgeny avatar Mar 15 '23 15:03 fnevgeny

I tried that, but somehow no font that I tried worked, even though it renders fine it so many places. However, I installed some additional fonts (namely the Google Noto Fonts) and now it works without the patch. I guess this makes this pull request obsolete in some sense, unless you think other people might want to have the option to change the symbols.

jonasc avatar Mar 15 '23 17:03 jonasc

I tried that, but somehow no font that I tried worked, even though it renders fine it so many places. However, I installed some additional fonts (namely the Google Noto Fonts) and now it works without the patch.

Well, if you have time to somehow debug it (I'm not a specialist in fonts etc), I'd be interested to understand the reason for this.

I guess this makes this pull request obsolete in some sense, unless you think other people might want to have the option to change the symbols.

@AndreasBilke, what do you think? Frankly, I initially intended to make the symbols with SVG icons but was too lazy :). Maybe we can put this on hold until the entire "bottom" area gets proper attention (#624, #679).

fnevgeny avatar Mar 16 '23 07:03 fnevgeny

Well, if you have time to somehow debug it (I'm not a specialist in fonts etc), I'd be interested to understand the reason for this.

I'll have a look if I have the time, but for now, I wouldn't even know where to start looking as I don't have much knowledge of the inner workings of fonts, font-selection, etc. as well.

jonasc avatar Mar 16 '23 09:03 jonasc

@AndreasBilke, what do you think? Frankly, I initially intended to make the symbols with SVG icons but was too lazy :). Maybe we can put this on hold until the entire "bottom" area gets proper attention (#624, #679).

Sure, but we never know when this happens :) So as a "quick fix" to make things better in the short run this PR might be a good solution.

AndreasBilke avatar Mar 17 '23 08:03 AndreasBilke

Sure, but we never know when this happens :) So as a "quick fix" to make things better in the short run this PR might be a good solution.

Yes, but then this option should be kept maintained for ever (well...). Let's wait until the next release is about to be ready, and if this PR is still relevant, apply it.

fnevgeny avatar Apr 01 '23 18:04 fnevgeny