Patrick Fowler

Results 30 comments of Patrick Fowler

The more you know™ ... thanks for the reference. I think the `else` approach would be overkill and this can be merged as-is. Now to see if this will help...

This is an interesting idea that I've toyed with over the years. My fear is that it could be a bit of a footgun. In our project, some job processors...

> Does the multi processors feature only work for “predefined” jobs but not dynamic jobs? @jackylee941130 that is correct to the best of my knowledge. Job definitions are stored in...

@rodolfoviolac & @gabriel1lima thanks for the votes, but instead of "+1"-ing, please use the reactions (thumbs up or otherwise) to "vote" for issues, and/or subscribe in the sidebar to receive...

Proposing we close this as pause/resume implementation is near identical to the existing enable/disable functionality. [From PR in the `pause.js` file](https://github.com/agenda/agenda/pull/894/files#diff-7fd9318bca08181664bc70e8b8f35bbacaea20bd912a381bf06301e77d26aa1aR8-R11) ``` // Pause module.exports = function() { this.attrs.disabled =...

I'd suggest looking into one or more of the following: * Custom JS Validators: https://foxhound87.github.io/mobx-react-form/docs/validation/modes/vjf-custom.html * onChange/onToggle Hooks: https://foxhound87.github.io/mobx-react-form/docs/events/event-handlers.html * observe/intercept: https://foxhound87.github.io/mobx-react-form/docs/extra/mobx-events.html

I'd either use a separate mobx store, or use the `extra` state property added in [#220](https://github.com/foxhound87/mobx-react-form/issues/220#issuecomment-291095427). In your `onSubmit` handler, you can check `form.state.extra.isLoading` and abort if necessary. In addition,...

I’d confirm that `extras.isLoading` is observable and that your component can respond to it. As for stopping onSubmit, typically I’d set valid = false, but there may be a cleaner...

Depending on how many actions you have enabled in your config, you may be able to collapse the Text Suggestion using the right-facing chevron icon on the left side of...

Are there any ways to hook in an `onClick` handler to cells? This seems like a heavily customizable library, if an onClick could be setup, it would allow the user...