pdfminer.six icon indicating copy to clipboard operation
pdfminer.six copied to clipboard

Switch to pyproject.toml (using hatchling)

Open dhdaines opened this issue 1 year ago • 2 comments

Pull request

Switch to pyproject.toml. I used hatch or more specifically its build backend hatchling because it was convenient, but we could also use plain old setuptools if you prefer! Fixes #931

How Has This Been Tested?

hatch run build
hatch shell
pip install -e .[dev]
nox

Checklist

  • [x ] I have read CONTRIBUTING.md.
  • [x ] I have added a concise human-readable description of the change to CHANGELOG.md.
  • [x ] I have tested that this fix is effective or that this feature works.
  • [x ] I have added docstrings to newly created methods and classes.
  • [x ] I have updated the README.md and the readthedocs documentation. Or verified that this is not necessary.

dhdaines avatar Jul 31 '24 20:07 dhdaines

Note that the output sdist and wheels end up being named pdfminer_six-... and not pdfminer.six-.... This is probably a good thing but I don't know if it will cause problems for PyPI?

dhdaines avatar Jul 31 '24 21:07 dhdaines

The test failure above is some random GitHub failure, not an actual problem with this PR.

dhdaines avatar Aug 06 '24 01:08 dhdaines

Note that the output sdist and wheels end up being named pdfminer_six-... and not pdfminer.six-.... This is probably a good thing but I don't know if it will cause problems for PyPI?

That is actually a good thing, because PyPi recently send me a notification that our package name should contain pdfminer_six but does not.

pietermarsman avatar Mar 24 '25 22:03 pietermarsman

Okay, should be good with plain setuptools now! I can't test the github workflows though...

dhdaines avatar Mar 25 '25 01:03 dhdaines