pdfcpu icon indicating copy to clipboard operation
pdfcpu copied to clipboard

Published 20 hours ago • verified publisher icon pdfcpu

Fix JS build

Open scoiatael opened this issue 3 years ago • 6 comments

Hey,

looks like WASM version stopped building some time ago.

$ env GOOS=js GOARCH=wasm go build
# github.com/pdfcpu/pdfcpu/pkg/pdfcpu
../../pkg/pdfcpu/parseConfig_js.go:219:28: too many arguments in call to handleHeaderBufSize
        have (string, string, *Configuration)
        want (string, *Configuration)

This fixes the problem. Maybe WASM build should be added to GH actions since it has some build-specific files?

scoiatael avatar Jun 02 '22 10:06 scoiatael

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jun 02 '22 10:06 CLAassistant

Thanks for discovering this. A separate Github action does make sense.

hhrutter avatar Jun 10 '22 18:06 hhrutter

Should I add the new action in this PR or is it good to go? :)

scoiatael avatar Jun 14 '22 08:06 scoiatael

If you can add it that would be nice. There is already an OS matrix in test.yml and this does not fit in. I guess we need another workflow then triggered by push, pull_request.

hhrutter avatar Jun 14 '22 10:06 hhrutter

Done - new workflow should cross-compile from Linux to a couple of standard targets. Looks like it needs approval before it can run, so kinda hard to verify if it works by myself.

scoiatael avatar Jun 15 '22 08:06 scoiatael

Thanks, this will go live together with the upcoming release.

hhrutter avatar Jun 16 '22 06:06 hhrutter

Fixed as of v0.4.0

hhrutter avatar Mar 01 '23 08:03 hhrutter

Fixed as of v0.4.0

Looks like it was closed, but not merged? I see that the original issue seems to be fixed in 0.4.0, but the Github workflow is not there.

scoiatael avatar Mar 03 '23 14:03 scoiatael

Your contribution was integrated into the main workflow. Had a lot of headache going on with refactoring.. Hope that's ok with you. 🙏 Thank you!

hhrutter avatar Mar 07 '23 01:03 hhrutter