Pedro Holanda

Results 54 comments of Pedro Holanda

Hm, so in this case we have to map whatever it comes to an runtime error of sorts? and just pass on the message?

Hey @nicku33, I've coded a solution for this issue already (will patch it tomorrow), the idea is to cache database instances for connections created over the same db file. That...

@gforsyth I've created this issue as a tracker for myself. I think we should have a look at queries 03/05/10 that stopped working after we both updated to the latest...

@gforsyth "quick" questions, I'm trying to build tests for Ibis consuming DuckDB plans, is there a quick (non-dirty) way to turn the bytes from ``` python proto = duck_con.get_substrait(query).fetchone()[0] ```...

> Sure, so from `proto` which is the raw byte-string, you can do the following: > > ```python > from ibis_substrait.proto.substrait import plan_pb2 > > plan = plan_pb2.Plan() > plan.ParseFromString(proto)...

I did, now they break for different reasons. ``` AILED test_duckdb_ibis_tpch.py::test_query_substrait_ibis_to_duck_01 - ValueError: Ibis Consumption: getattr(): attribute name must be string FAILED test_duckdb_ibis_tpch.py::test_query_substrait_ibis_to_duck_02 - ValueError: Ibis Consumption: pop from an...

Hey @gforsyth, just a heads up, I spent the whole day today integrating the Substrait Validator and fixing issues with it, so wait for that before checking anything related to...

Moving this issue to: https://github.com/duckdblabs/substrait/issues/4

Hi, @wisp3rwind thanks for your PR. Could you please add test cases to the fetch functions you added? I'm also not sure how I feel about many aliases to the...

I would say we can keep ```df()``` and ```fetch_df()```, ```numpy()``` and ```fetch_numpy()``` and merge all arrow functions with a flag to output either an arrow table or a record batch...