go-binance icon indicating copy to clipboard operation
go-binance copied to clipboard

Files in binance/tests are not in the same package

Open scottjbarr opened this issue 6 years ago • 0 comments

The files in binance/tests are declared as being in different packages.

$ grep -h package binance/tests/*.go
package account_test
package market_test
package ping_test
package withdrawal_system_status_test

This breaks Go tooling elsewhere that encounters these files. For example, gorename will not work if it sees these files.

It also means you can't just run go test ./....

In Go the most common convention you'll find is to keep the test files with the source files, but I see these are more like integration tests (requiring actual credentials), so maybe they are better off as commands?

scottjbarr avatar Aug 23 '18 22:08 scottjbarr