pdepend icon indicating copy to clipboard operation
pdepend copied to clipboard

Issue 892: Add test for PHP8.4 property hook support

Open mwolff-fn opened this issue 7 months ago • 3 comments

Type: testcase contribution Issue: #892 Breaking change: no

Adds a testcase to demonstrate parser issues with PHP8.4 property hooks and asymmetric visibility.

mwolff-fn avatar Jun 05 '25 10:06 mwolff-fn

Thanks this looks good, but please revert the PHPUnit requirement changes

AJenbo avatar Jun 05 '25 11:06 AJenbo

Thanks this looks good, but please revert the PHPUnit requirement changes

Done - for me, this means I can no longer run either "composer install" on PHP 8.4, nor can I execute the test suite - but maybe there's yet another PR for that or some other magic bullet that I'm not aware of ;-)

mwolff-fn avatar Jun 05 '25 11:06 mwolff-fn

Thanks this looks good, but please revert the PHPUnit requirement changes

Done - for me, this means I can no longer run either "composer install" on PHP 8.4, nor can I execute the test suite - but maybe there's yet another PR for that or some other magic bullet that I'm not aware of ;-)

You can instead set it to allow multiple versions, but make sure not to put it as a runtime requirement.

AJenbo avatar Jun 05 '25 11:06 AJenbo