Enforcing header names?

[afragen]

Do we want to enforce the use of predefined headers, GitHub Plugin URI, BitBucket Plugin URI vs generic Git URI?

I think there can be unintended consequences for just parsing the Plugin URI, like those plugins hosted on both WP.org and GitHub? In a quick check I see that one of my .org plugins shows to update and the update wants to pull from GitHub.

I think we should parse based upon a predefined header.

[pdclark]

I'm fine with at least reducing it to an option that has to be turned on with a filter:

if ( apply_filters( 'ghu_parse_plugin_uris', false ) ) { /*...Look at those headers...*/ }

Or once there's an admin, those repos could be shown, but off by default.

Certainly agree that it should be turned off by default.

[afragen]

The problem with it being defaulted off is that any .org plugin with the header Plugin URI: https://github.com/… is going to try and be updated from GitHub and not from .org

[pdclark]

I may have not written clearly. I'm saying Git updates from Plugin URI off by default. The consequence being that any plugin with a Git address in Plugin URI would not be updated by Git. It would be updated by .org.

[pdclark]

PluginURI has been disabled for Git updates in https://github.com/brainstormmedia/git-plugin-updates/commit/20fb1ac2228b484b7b59f35e684a5c2410ce6cc7

[pdclark]

Is this now a duplicate of #20, or is there another component I'm missing?