soundbounce icon indicating copy to clipboard operation
soundbounce copied to clipboard

Last.fm scrobbling [$45]

Open pdaddyo opened this issue 10 years ago • 25 comments

--- There is a **[$45 open bounty](https://www.bountysource.com/issues/7139434-last-fm-scrobbling?utm_campaign=plugin&utm_content=tracker%2F9578624&utm_medium=issues&utm_source=github)** on this issue. Add to the bounty at [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F9578624&utm_medium=issues&utm_source=github).

pdaddyo avatar Dec 19 '14 15:12 pdaddyo

As mentioned in the room: +1 for this!

chrisb92 avatar Dec 19 '14 16:12 chrisb92

+1 as well :+1:

Papipo avatar Dec 21 '14 00:12 Papipo

I'm looking into this as we speak, @pdaddyo has some reworks coming up so I'll focus on a small seperate part that should easily fit in.

PaddoSwam avatar Dec 22 '14 12:12 PaddoSwam

Add another +1 :+1:

bgod avatar Dec 22 '14 21:12 bgod

Requires #100 to be done first, then this will be added in.

pdaddyo avatar Dec 23 '14 00:12 pdaddyo

FYI @PaddoSwam I've already got this working on Windows, haven't looked into it on OSX just yet. I'll be exposing the last.fm user/pass via the spotifyBrowserApi so it will be cross-platform, not c# specific.

pdaddyo avatar Dec 23 '14 00:12 pdaddyo

Just realised that this should probably go on the login screen (under a collapsible "last.fm" section), since the details need to be sent to spotify on login, not after.

pdaddyo avatar Dec 24 '14 12:12 pdaddyo

I would love to see this on OSX soon, +1 here too :+1:

danhumphries89 avatar Jan 09 '15 12:01 danhumphries89

:+1:

danielsamuels avatar Jan 10 '15 22:01 danielsamuels

As user, I think this enhancement has high priority, because last.fm users don't like players that can't scrobble. I'm not a developer, but maybe the scrobbling does not necessarily be made trough spotify: players like winamp and many more can srobble by itself...

gucklar avatar Jan 26 '15 15:01 gucklar

I know I'll use the app a lot more once scrobbling is supported. Maybe it's time to put a bounty on it?

https://www.bountysource.com/issues/7139434-last-fm-scrobbling?utm_campaign=plugin&utm_content=tracker%2F9578624&utm_medium=issues&utm_source=github

bgod avatar Jan 26 '15 15:01 bgod

I just added to the bounty because I discovered SoundBounce and I think it would be an AWESOME addition to have Last.fm scrobbling. Until it's there I'll just keep discovering new tracks using SoundBounce, but I'll listen to them as much as possible through the original client to make the scrobbles happen...

DJFliX avatar Apr 01 '15 21:04 DJFliX

Thanks for feedback. Can I quickly ask - are you a Windows user?

pdaddyo avatar Apr 02 '15 09:04 pdaddyo

I'm a Mac user

DJFliX avatar Apr 02 '15 10:04 DJFliX

:+1:

ikt avatar Apr 30 '15 20:04 ikt

Is this issue still applicable?

USA-RedDragon avatar Nov 01 '15 21:11 USA-RedDragon

Yes, still applicable!

beveradb avatar Nov 02 '15 09:11 beveradb

How would the dev's like to handle api key required for this to work?

USA-RedDragon avatar Nov 02 '15 15:11 USA-RedDragon

This is quite easy to implement if we read the last.fm details from a config file (literally like 2 lines of code in the C# build, code would sit here:

https://github.com/pdaddyo/soundbounce/blob/master/src/SoundBounce.Spotify.API/Session.cs#L283

However, this would require releasing a new native client, something we've not had to do since launch. This is why it's not been done yet, because we don't have a system in place for automatic native client updates. Also not sure if node's spotify library (as used on linux / osx) supports last.fm scrobbling at all.

So this is why I decided to leave this until the new desktop Spotify SDK drops (still awaiting word from Spotify on this - libspotify that we are currently using has been officially deprecated). FYI The bounty isn't claimable unless it's implemented on OSX + Linux too, that's where the focus would need to be since it's so easy to implement on Windows.

pdaddyo avatar Nov 02 '15 16:11 pdaddyo

https://github.com/pdaddyo/soundbounce/tree/master/src/client-node-webkit/node-spotify-master This is the library for OSX/Linux? And I work better on those platoforms, I hate c# lol

USA-RedDragon avatar Nov 02 '15 17:11 USA-RedDragon

Or is it this: https://github.com/pdaddyo/node-libspotify

USA-RedDragon avatar Nov 02 '15 17:11 USA-RedDragon

It's this one https://github.com/pdaddyo/soundbounce/tree/master/src/client-node-webkit/node-spotify-master

pdaddyo avatar Nov 02 '15 17:11 pdaddyo

OK, I think I got this :+1:

USA-RedDragon avatar Nov 02 '15 17:11 USA-RedDragon

For Linux, and OSX can we either include or have them install liblastfm? It's officially open sourced and maintained by lastfm, and there's no use in rewriting a perfectly fine library.

USA-RedDragon avatar Nov 02 '15 17:11 USA-RedDragon

Scrobbling is supported natively by libspotify which is already included (simply by supplying last.fm credentials at login), see here https://developer.spotify.com/docs/libspotify/12.1.51/group__session.html#ga2475a1fbc2eeacccb96b7f36efd36725 - so I'd rather not include another dependency if possible.

pdaddyo avatar Nov 03 '15 09:11 pdaddyo