octohint icon indicating copy to clipboard operation
octohint copied to clipboard

Hint view is clipped

Open aerze opened this issue 7 years ago • 2 comments

First, awesome extension 🥇

I tested it by immediately browsing this same repo and the hint gets clipped by the code view.

You can reproduce by going to octohint/scripts/get-node-libs.js and hovering over fs.readFileSync

screen shot 2017-12-13 at 13 08 29

aerze avatar Dec 13 '17 21:12 aerze

Fixable via position: absolute; on $background div. At least in chrome this works.

ideadapt avatar Dec 16 '17 17:12 ideadapt

@ideadapt Thanks. Actually it is absolute at first. We change it to relative to fix #10.

I think it is better to calculate the height, then decide to show it up or down, to make sure it is not clipped.

pd4d10 avatar Dec 28 '17 13:12 pd4d10