Rongjian Zhang

Results 55 issues of Rongjian Zhang

`var SafariView = require('react-native-safari-view').default` is what users want Use `import` instead to make it clear Related: #57

This PR uses rollup instead of webpack to build production bundles: - [x] ESM bundle (`dist/mesh.esm.js`): For ES Module with tree-shaking - [x] UMD bundle (`dist/mesh.js`): For CommonJS, AMD and...

There are some unnecessary files published to npm: https://npmview.now.sh/@mesh.js/core Use `files` in package.json so we don't need to worry about updating the npmignore the next time

For example: ```gql query TestDirective($test: Boolean!) { human(id: "a") { name @include(if: $test) id @skip(if: $test) } } ``` Generated `data.gql.dart`: ![image](https://user-images.githubusercontent.com/9524411/104901833-db1e9080-59b8-11eb-8be8-deb541fe5054.png) Should it be: ```dart @nullable String get name;...

Take part of [this file](https://github.com/apache/thrift/blob/master/test/ThriftTest.thrift) as example: ```thrift /* * with the License. You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by...

Like this: ```thrift namespace js test // trailing comment ``` Output: ```json { "type": "ThriftDocument", "body": [ { "type": "NamespaceDefinition", "scope": { "type": "Identifier", "value": "js", "loc": { "start": {...

bug
help wanted

### Description Add final newline for `pacakge.json` to keep consistent with other files. ### Additional context --- ### What is the purpose of this pull request? - [x] Bug fix...

Prerequisites of #392 , to make sure the styles are correct. Before https://github.com/ast-grep/ast-grep/issues/156#issuecomment-1551768759 gets confirmed, use hard code instead.

A part fix of #156 , only applied for errors' style. For this case, I also tested at my local machine and it should work correctly. If we need more...