debugtron icon indicating copy to clipboard operation
debugtron copied to clipboard

adapt some logic on linux

Open jerry4718 opened this issue 2 years ago • 2 comments

  • adapt find app on linux
  • compat show icon on linux (sync implement)

jerry4718 avatar Jan 17 '23 09:01 jerry4718

Some logic reference here Icon Theme Specification I have only tested it on my deepin Linux, and it is reasonable to use it

jerry4718 avatar Jan 17 '23 09:01 jerry4718

I think the problem of can not find module 'simple-plist' can be solved completely in this way Change the import of adapter to dynamic import

Because simple-plist should not be directly imported when it is released to win or linux. It is not useful for win or linux because it is a module that only implements some functions for mac os.

If electron-forge has the ability of conditional compilation, I think adapter should be handled in that way.

jerry4718 avatar Jan 20 '23 04:01 jerry4718

Sorry for the late reply.

There seems to be a lot of conflict since the lastet main branch has significant changes. Could you please run a rebase? Then we can merge this PR

the problem of can not find module 'simple-plist'

I'm not sure if this issue still exists. If yes then fixes are very welcome

Thanks!

pd4d10 avatar Jul 09 '24 13:07 pd4d10

Sorry for the late reply.

There seems to be a lot of conflict since the lastet main branch has significant changes. Could you please run a rebase? Then we can merge this PR

the problem of can not find module 'simple-plist'

I'm not sure if this issue still exists. If yes then fixes are very welcome

Thanks!

okay, let me see

jerry4718 avatar Jul 09 '24 13:07 jerry4718

There seems to be a lot of conflict since the lastet main branch has significant changes. Could you please run a rebase? Then we can merge this PR

I am not very proficient in rebase, so I created a new PR ( #35 )

jerry4718 avatar Jul 10 '24 02:07 jerry4718