ruby_route_53 icon indicating copy to clipboard operation
ruby_route_53 copied to clipboard

Add support for `UPSERT` type of actions

Open luk4s opened this issue 6 years ago • 1 comments

Current implementation of update method is DELETE and CREATE (https://github.com/pcorliss/ruby_route_53/blob/f96fab52931f069ba4b5fddb291aa53c7412aa52/lib/route53/dns_record.rb#L66-L77).

I suggest to change it to action UPSERT, which AWS describe as update of record set (see https://docs.aws.amazon.com/Route53/latest/APIReference/API_ChangeResourceRecordSets.html)

This change optimize our workflow with DNS record sets.

Make this feature sense for you ? Do you prefer implement new method upsert instead of change current update ?

Thx

luk4s avatar Dec 16 '19 08:12 luk4s

Hi @luk4s,

I think an UPSERT would work just fine in place of the DELETE and CREATE. At the time this was written UPSERT hadn't yet been added to the spec.

A word of caution however. This project still works however it is not actively maintained. As you can see the last commit was 2017, and the first commit was 9 years ago. While I'm happy to review your changes, run the test suite, and publish a new release you should exercise some caution when using the gem.

Phil C

pcorliss avatar Dec 18 '19 03:12 pcorliss