pcopissa

Sorry but I am now stuck with a non-functional Hanami 2.1 after 2.2 came out (#1470). I am still struggling to get Hanami 2.1 working after the forced upgrade that...

So I am back with a (mostly) working Hanami 2.1... ## missing `public/assets/assets.json` @kyleplump > so the file is correctly created after you &:join the threads? Yes, `assets.json` was created...

An update about `no asset found for "favicon.ico"` error: I finally gave a proper look at the stack trace shown when this error occurs: The exception is raised at line...

A head up: I updated the conversation https://github.com/hanami/assets-js/pull/31 (improved the proposed modifications and added a proposed fix for `no asset found for "favicon.ico"` ).

Update: - I looked up the proposed solution for the `NotImplementedError`, tried it and it failed. - Found an alternative fix that does not crash `bundle exec hanami assets compile`...

Looks like `dry-files` has no provision for binary-vs-text neither when reading nor when writing files. `dry-files-1.1.0/lib/dry/files.rb` has two constants: ``` OPEN_MODE = ::File::RDWR WRITE_MODE = (::File::CREAT | ::File::WRONLY | ::File::TRUNC).freeze...

The proposed fix does not work on a Windows platform: the `rescue NotImplementedError` block is never called. The code below does not crash and `hanami assets compile` terminates without error....

Hi @timriley I appreciate your offer but the fact is that I am not familiar at all with Hanami code... I just read the error messages, searched the Github repo...

I took some time to investigate what's going on. TL;DR https://github.com/hanami/hanami/issues/1463#issuecomment-2455155518 longer version: https://github.com/hanami/hanami/issues/1463#issuecomment-2454538102