SalesforceApps icon indicating copy to clipboard operation
SalesforceApps copied to clipboard

getCometdURL argument mismatch

Open moblizeit opened this issue 5 years ago • 2 comments

in cometd_setup the call is

var url = getCometdURL(data.conn, data.args);

whereas the signature has only one parameter as below:

function getCometdURL(conn:any) { return conn.instanceUrl + '/cometd/44.0'; }

moblizeit avatar Oct 05 '20 04:10 moblizeit

Are you experiencing any issues because of that? Currently that method does not use any of the args and Javascript will just ignore any additional arguments passed. Because the args are not being used they were dropped from the method definition as to no have to add an eslint exception to the function declaration

pcon avatar Oct 05 '20 14:10 pcon

well no issues just pointed as i use typescript and with tighter grammar rules it complains about it.

moblizeit avatar Oct 05 '20 16:10 moblizeit