Paul Chote
Paul Chote
The first and third commit LGTM. For the second commit, i'm not a fan of having to add production-related details on the `IMove` interface. The real problem here is the...
Thinking about this more, I wonder whether the better solution would be to remove `TakeOffOnCreation` completely, and have the decision to take off or not be based on whether the...
Hmm... I think the most reasonable behaviour there would be to check if it was placed on an airfield (Aircraft already does this) then it should stay there landed, otherwise...
That would be better yeah, so long as we also fix the editor so that they (aircraft placed on terrain that isn't in its `LandableTerrainTypes` list) are placed at their...
TBH i'm not comfortable with this. I've been happy to direct people to baxxster when they approach us informally on discord etc, but if we are going to formally advertise...
See also #20053. `exec` smells suspicious here. I was expecting that this fix would explicitly check for mono/dotnet when processing the `.in` and either call mono or the compiled dotnet...
IMO exposing `TryGetImage` methods would present a cleaner API than the `logNotFound` bool.
Can we please add a short comment at each code location explaining that the order is important for cache consistency?
This is caused by https://github.com/libsdl-org/SDL/commit/3046d55d0e9058d47df1abf41fea1e51c1cd7fd5 in SDL 2.24, which I expect will cause the same issue on intel macs. Downgrading to SDL 2.20 to match our precompiled intel lib should...
The worst part of this was probably introduced by a28be21e07641050df2a7039096280e7f39e0561, which makes us we call the expensive `MoveAdjacentTo.CalculatePathToTarget` method 4 times per unit per tick instead of just once. The...