Pavel Tcholakov
Pavel Tcholakov
@tillrohrmann somewhat; there is coverage for all the mentioned scenarios but it only exercises the cluster controller, not integrated. I'd like to keep this issue open for now please -...
@tillrohrmann we definitely do not have these, not what I think of as integration tests; we have very good unit test coverage of these paths and indirect integrated test coverage...
Ok, I am a giant dummy - I see why this is not easy. If we don't want to delay the Prometheus recorder initialization until after we know our own...
Ack, I'll review and update.
Did not get a chance to benchmark this, but pushed an update to use `parking_lot`.
This has been starved for attention; I've started a [conversation with the upstream owners about enabling updates to global labels](https://github.com/metrics-rs/metrics/issues/580) post-creation in `metrics-exporter-prometheus`, will reopen in the future depending on...
From @tillrohrmann: > With the global total order log the shuffle will probably go away and improving it might not be worth it at this point. Let's not pick this...
@ashish111333 Hey, absolutely! If you're interested please pick this up :-)
Thanks for taking a look, @tillrohrmann! Good points, addressed both. Docs will definitely need an update but there are a couple more PRs in this train and I'll take a...