Pat Hickey comments

Results 236 comments of


                                            Pat Hickey

String size of mangled function names could be exponentially large

A world is more specific than a library (like wasi-libc) or crate (like `std`, or `fastly`) that uses interfaces available in many different worlds. So, just encoding a wit rather...

component model: async host function & embedding support

Thanks! I just need to write some tests.

Implement wasi-filesystem in Wasmtime

This is gated behind `wit-bindgen-gen-host-wasmtime-rust` being rewritten for components

fix: check filetype in `path_open`

@npmccallum OK, send a PR to fix it then

Direct usage of WASI causing breakage during snapshot migration

That makes sense - the wasi runner component (wasi-common, for wasmtime and lucet) can't be compatible with newer versions of WASI than existed when it was created, but we are...

Publish wasi-nn Rust bindings here?

Agreed with Alex that the long term isnt clear, but for now we should start by getting the Rust code generator in this crate working for all proposals. I don't...

generate-raw does not understand pointers as parameters

Yeah that does look like a bug - should be an `unimplemented` rather than `unreachable`. Its just a case that doesn't happen to occur in WASI at this time. The...

`strerror` function only generated for `Errno`

Can't we just `#[derive(Debug)]` on all enums?

`strerror` function only generated for `Errno`

oh! my bad. Maybe we should define a `trait WitxDocs { fn docs(&self) -> String }` and generate impls for that?

Add WasiCtxBuilder::preopened_handle to allow more flexible VFS usage

Yes this has been possible in wasi-common for a few years now. Note that this functionality is going away in the preview 2 implementation, in favor of using component virtualization...