Pat Hickey

Results 236 comments of Pat Hickey

Yes, it would. Is that a problem? We don't have to land this now - it could wait, or we could make a separate CI build that modifies it to...

OK: I will remove the upgrade of edition and msrv, I will switch this to lint that the libraries are compatible with the 2024 edition, which keeps the upgrade delta...

@bavshin-f5 I made another pass to minimize the size of all the added unsafe {} blocks

Its pretty nontrivial to upgrade from wasm-compose to wac. Wasi-virt's s use of wasm-compose reflects that wasi-virt itself is not well maintained at the moment. Long story short, wasi-virt is...

Yes there are all the problems with virtualizing wasi:io in terms of performance (creates intermediate copies of all stream contents) and trust boundary (wasi-virt has to virtualize all io, must...

I also suspect that noone is using >32 flags. Lets push out this restriction in wasm-tools's validator, and if nobody complains within a month or so, we have confirmed its...

I have granted @alexcrichton write privs so that his review of this makes it green. I think this is ready to go?

The example in wstd is just trying to read out the values of trailers - returning none trailers, like wasmtime does, is a suitable implementation. Wasmtime doesn't have any path...

@bchalios, you contributed `open_file_descriptor`, can I assign this to you?