Paul Chaignon
Paul Chaignon
Thanks for the contribution! Could you give a bit of context in the commit description, also describe how you tested this, and fix the CI failure? I'll mark as draft...
@behzad-mir Are you sure you tested this version? If you did, could you explain how you enabled the feature? Looking at the code and trying the image as follows, I...
Ah, nice to know that's all that's needed for ConfigMap setups. But yeah, we'll need the agent flag fully defined for those of us who run Cilium on baremetal and...
Thanks for the update! The two failures in CI are genuine and will need to be addressed.
/test @behzad-mir Only organization members have permissions to trigger end-to-end tests. See https://pchaigno.github.io/cilium/2024/12/05/first-cilium-pull-request.html#how-and-when-to-move-up-the-contributor-ladder.
Could you also add a release note to the PR description (see the template)? It will be displayed in release notes so it needs to be understandable by users. You...
#2224 fixes this.
Thanks everyone for the reviews! That was really helpful! I believe I addressed all comments. I also reworked the flow diagram (sources uploaded) by taking inspiration from the one Gray...
Looks fine to me, but I think the syntax should be: ``` spec: selectors: - podSelector: matchLabels: test-gateway: "true" nodeSelector: # Note the lack of dash here. matchLabels: kubernetes.io/hostname: node01...