Peter Collingbourne

Results 35 comments of Peter Collingbourne

> Are there figures on how many regular relative relocations are transformed into R_AARCH64_AUTH_RELATIVE under PAuthABI? The 32b limit was chosen on the basis that in the vast majority of...

Got it, I misread your earlier message and thought you were asking about `.rela.dyn` -> `.relr.auth.dyn` rather than `R_AARCH64_ABS64` -> `R_AARCH64_AUTH_ABS64`. Let me see if I can collect those numbers...

I built AOSP with PAuth ABI disabled and enabled for the Cuttlefish (i.e. emulator) arm64 target and ran the following commands from the `symbols` directory of the build directory, which...

(I bet this is the real fix for #702.)

> Thanks, can you tell me how to reproduce this? IIUC just make the source file unreadable or something like that, yes? Right, or just delete the source file. I...

Sure, here is before/after ![Screenshot from 2025-05-26 15-36-47](https://github.com/user-attachments/assets/bb12b20b-4e8e-48e7-9cf0-141b96c02284) ![Screenshot from 2025-05-26 15-39-52](https://github.com/user-attachments/assets/7912b8f0-a269-498a-b094-0f401bbb7604)

Thanks. I was having some trouble figuring out how to run the tests yesterday, `make test` failed with missing binariers so it seemed like I would need to build the...

> hm the normal build should also include tests, I run those via `ctest --output-on-failure -j8` or similar myself. the CI clazy/clang-tidy jobs are sadly broken, please ignore those for...

Also proposing that the new relocation type would always write a little-endian value regardless of the target endianness because A64 instructions are always little-endian.

> If the relocation is an instruction rather than data relocation, the little-endianness should drop out from that. Ack > Ideally this relocation would apply only to instructions without static...