espressif icon indicating copy to clipboard operation
espressif copied to clipboard

Published 20 hours ago • verified publisher icon pcbreflux

Wire.beginTransmission() and Wire.endTransmission() should not be used together with Wire.requestFrom().

Open Koepel opened this issue 6 years ago • 0 comments

The Wire.beginTransmission() and Wire.endTransmission() should only be used when writing data. I noticed two files where they were used before and after a Wire.requestFrom(). Those can be removed. Explanation: Common-mistakes, number 2 and 3.

  • espressif/esp32/arduino/sketchbook/ESP32_SI7060_INA219/i2c_SI7060.cpp (currently at line 31 and 34)
  • espressif/esp32/arduino/sketchbook/ESP32_i2c_Si7021_oled/ESP32_i2c_Si7021_oled.ino (currently at line 27 and 31).

Koepel avatar Sep 06 '18 23:09 Koepel